Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose stream parameter in public strings APIs #14260

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Expose stream parameter in public strings APIs #14260

merged 1 commit into from
Oct 10, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Add stream parameter to public APIs:

  • cudf::strings::strip()
  • cudf::strings::slice_strings()
  • cudf::strings::pad()
  • cudf::strings::zfill()
  • cudf::strings::wrap()

Also cleaned up some of the doxygen comments and added stream-tests.

Reference #13744

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 6, 2023
@davidwendt davidwendt self-assigned this Oct 6, 2023
@github-actions github-actions bot added the CMake CMake build issue label Oct 6, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 9, 2023
@davidwendt davidwendt marked this pull request as ready for review October 9, 2023 18:23
@davidwendt davidwendt requested a review from a team as a code owner October 9, 2023 18:23
vyasr
vyasr approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidwendt davidwendt mentioned this pull request Oct 10, 2023
Open
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5039d04 into rapidsai:branch-23.12 Oct 10, 2023
60 checks passed
@davidwendt davidwendt deleted the stream-strings-apis branch October 10, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@ttnghia ttnghia ttnghia approved these changes

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @vyasr @ttnghia