Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the use of volatile in ORC #14175

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Remove the use of volatile in ORC #14175

merged 4 commits into from
Oct 3, 2023

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Sep 22, 2023

Description

volatile should no be required in our code, unless there are compiler or synchronization issues.
This PR removes the use in ORC reader and writer.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule self-assigned this Sep 22, 2023
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 22, 2023
@vuule vuule added Performance Performance related issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change cuIO cuIO issue and removed libcudf Affects libcudf (C++/CUDA) code. labels Sep 22, 2023
@vuule
Copy link
Contributor Author

vuule commented Sep 22, 2023

Aiming to merge early in the release so there's plenty of time for ahem field testing.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 25, 2023
@vuule
Copy link
Contributor Author

vuule commented Oct 2, 2023

The PR increases throughput in benchmarks on average by 16%.

@vuule vuule marked this pull request as ready for review October 2, 2023 18:52
@vuule vuule requested a review from a team as a code owner October 2, 2023 18:52
PointKernel
PointKernel approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice free speedups.

@vuule
Copy link
Contributor Author

vuule commented Oct 3, 2023

/merge

@rapids-bot rapids-bot bot merged commit 29556a2 into rapidsai:branch-23.12 Oct 3, 2023
63 checks passed
@vuule vuule deleted the perf-remove-volatile-orc branch October 3, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@PointKernel PointKernel PointKernel approved these changes

Assignees

@vuule vuule

Labels
cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Performance Performance related issue
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vuule @bdice @PointKernel