-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for dependency (scipy and pandas) updates #234
Fixes for dependency (scipy and pandas) updates #234
Conversation
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
- Coverage 98.93% 98.81% -0.12%
==========================================
Files 19 19
Lines 3282 3290 +8
Branches 529 529
==========================================
+ Hits 3247 3251 +4
- Misses 18 22 +4
Partials 17 17
Continue to review full report at Codecov.
|
Hi @adamnarai, Thank you, this is great! I haven't checked but I am guessing that we should also remove the call to pingouin/pingouin/correlation.py Lines 647 to 648 in 72e447d
and pingouin/pingouin/correlation.py Lines 865 to 866 in 72e447d
|
You're right, it's better to remove it from here too (I think it wasn't used elsewhere), I added a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge!
Merging now, thanks! |
Fixed the bug from #232
To pass unit tests I also:
Implemented your fix @raphaelvallat from #227
DataFrame.apply() does not copy dtypes for some reason ant it is also deprecated (https://pandas.pydata.org/pandas-docs/version/1.4.0/whatsnew/v1.4.0.html), causing unit tests to fail, so I replaced the following line
pingouin/pingouin/pairwise.py
Lines 461 to 462 in dcfdc82
with