Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI, Makefile and PR template #76

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Add CI, Makefile and PR template #76

merged 4 commits into from
Apr 23, 2024

Conversation

tomleb
Copy link
Contributor

@tomleb tomleb commented Apr 9, 2024

Issue: rancher/rancher#44970

This is a redo of #73 but without the -race flag because it's inconsistently failing due to a race condition.

Problem & Solution

Couple of things:

  • This repository is not running any tests when creating PRs. Let's make it do that. I have
  • There aren't any commands to quickly run go test, go build, etc. I'm fixing this by adding a Makefile. We're not adding dapper though.
  • Add a PR template. I'm not sure if the template has to be merged before it starts working.. We'll see I guess?
  • Removing .drone.yml because it's only FOSSA and it isn't running at all: https://drone-publish.rancher.io/remotedialer.

CheckList

  • Test

@tomleb tomleb requested a review from a team as a code owner April 9, 2024 15:07
@tomleb
Copy link
Contributor Author

tomleb commented Apr 12, 2024

@aruiz14 Added you as reviewer since bullseyes is contributing to this repo so wanted to know your thought on at least the Makefile being added.

aruiz14
aruiz14 approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@aruiz14 aruiz14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

MbolotSuse
MbolotSuse approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@MbolotSuse MbolotSuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to allow for merge since this already has two approvals.

@tomleb tomleb merged commit 9da880f into rancher:master Apr 23, 2024
1 check passed
@tomleb tomleb deleted the add-ci branch April 23, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aruiz14 aruiz14 aruiz14 approved these changes

@JonCrowther JonCrowther JonCrowther approved these changes

@maxsokolovsky maxsokolovsky maxsokolovsky approved these changes

@MbolotSuse MbolotSuse MbolotSuse approved these changes

@nflynt nflynt Awaiting requested review from nflynt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomleb @aruiz14 @JonCrowther @maxsokolovsky @MbolotSuse