Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/ui: automate the reset feature test #995

Merged
merged 5 commits into from
Sep 8, 2023
Merged

ci/ui: automate the reset feature test #995

merged 5 commits into from
Sep 8, 2023

Conversation

juadk
Copy link
Contributor

@juadk juadk commented Sep 6, 2023 •
edited
Loading

Partially address #952

Tests only use the default values for the reset feature.

  • Enable reset at machine registration level, create a one-node cluster, delete it, and check if reset works as expected, then create a new cluster with the reset node. Only for K3S
  • Enable reset at machine inventory level, create a one-node cluster, delete it, and check if reset works as expected, then create a new cluster with the reset node. Only for RKE2
  • New tests added to QASE (53 and 54)

Verification runs

UI-K3s-Rancher_Stable ✅
UI-RKE2-Rancher_Stable ✅

@juadk juadk added the kind/QA label Sep 6, 2023
@juadk juadk self-assigned this Sep 6, 2023
@juadk juadk force-pushed the automate_reset_test branch 3 times, most recently from cf4b87e to 327ad9b Compare September 8, 2023 07:10
@juadk juadk marked this pull request as ready for review September 8, 2023 07:42
@juadk juadk requested a review from a team as a code owner September 8, 2023 07:42
ldevulder
ldevulder requested changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@ldevulder ldevulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small modifications.

tests/cypress/latest/e2e/unit_tests/reset.spec.ts Show resolved Hide resolved
tests/cypress/latest/support/utils.ts Show resolved Hide resolved
@juadk juadk mentioned this pull request Sep 8, 2023
Closed
ldevulder
ldevulder approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@ldevulder ldevulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juadk juadk merged commit 1861e45 into main Sep 8, 2023
16 checks passed
@juadk juadk deleted the automate_reset_test branch September 8, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldevulder ldevulder ldevulder approved these changes

Assignees

@juadk juadk

Labels
kind/QA
Projects
Elemental
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juadk @ldevulder