Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add elemental-register-reset.service #978

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Add elemental-register-reset.service #978

merged 1 commit into from
Aug 30, 2023

Conversation

anmazzotti
Copy link
Contributor

@anmazzotti anmazzotti commented Aug 29, 2023 •
edited
Loading

Resolves #977

@anmazzotti anmazzotti requested a review from a team as a code owner August 29, 2023 10:36
davidcassany
davidcassany approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidcassany davidcassany merged commit d301e1b into rancher:main Aug 30, 2023
10 checks passed
@juadk
Copy link
Contributor

juadk commented Aug 30, 2023

Tested successfully with the latest dev operator:
I tested it by unplugging the network cable when the machine rebooted on the recovery partition, I saw the elemental-register --reset command running every 5 seconds.
Then, I plugged my network cable back and the magic happened! All good! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcassany davidcassany davidcassany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elemental reset flow does not retry in case of failures
3 participants
@anmazzotti @juadk @davidcassany