Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop SLE Micro version references from code #914

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Drop SLE Micro version references from code #914

merged 3 commits into from
Aug 1, 2023

Conversation

davidcassany
Copy link
Contributor

These are the changes required in this repository for the builds I prepared in here.

Note this changes image and charts URLs, so this is likely to be a breaking change from CI perspective.

Part of #815

@davidcassany davidcassany requested a review from a team as a code owner July 14, 2023 10:00
@davidcassany davidcassany marked this pull request as draft July 14, 2023 10:00
@davidcassany davidcassany force-pushed the drop_slemicro_version_references_from_code branch 2 times, most recently from 939e38b to cdaf00c Compare July 14, 2023 10:03
kkaempf
kkaempf requested changes Jul 14, 2023
View reviewed changes
.obs/dockerfile/teal-iso/Dockerfile Outdated
#!BuildTag: rancher/elemental-teal-iso/5.3:latest
#!BuildTag: rancher/elemental-teal-iso/5.3:%VERSION%
#!BuildTag: rancher/elemental-teal-iso/5.3:%VERSION%-%RELEASE%
#!BuildTag: rancher/elemental-teal-iso:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this might fail while we build two versions (like 5.3 and 5.4) in parallel.

We should probably just drop the :latest tag ?!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In OBS builds this will end up being something like:

registry.org/home/cassany/elementalnewdev/containers/rancher/elemental-teal-iso:latest
registry.org/home/cassany/elementalnewdev/containers_next/rancher/elemental-teal-iso:latest

So there will not be an overlap as long as they build in different repositories. For IBS builds under registry.suse.com I see your point. If we follow other SUSE images approach we could keep it our latest code base stream build and remove it on old ones. Using suse/sle15:latest image as an example this shifted from SP4 to SP5 as soon as the new one was released. I agree this is quite annoying from maintenance point of view as this forces us to update the old build in any new release 🤔 also feels like this can be error prone if done manually.

.obs/dockerfile/teal-iso/Dockerfile Outdated
FROM rancher/elemental-builder-image/5.3:latest AS builder
ARG SLE_VERSION

FROM rancher/elemental-teal:latest AS os
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here ...

@davidcassany davidcassany force-pushed the drop_slemicro_version_references_from_code branch 5 times, most recently from 5fe40b4 to d9ade15 Compare July 27, 2023 16:58
kkaempf
kkaempf approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better now 😆

@davidcassany davidcassany force-pushed the drop_slemicro_version_references_from_code branch 2 times, most recently from 8c870d6 to 393f8a7 Compare July 31, 2023 20:31
@davidcassany
Drop SLE Micro version references from code
02afc29 
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany
Remove latest tags from teal-iso and teal images
41c2c71 
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany
Readd SLE Micro version within image repository
812c1c7 
Add again SLEMicro version within the repository to be sure we can still
make use of the 'latest' tag for each base distro version. Now it will
be dynamically computed from project configuration at the expense of
increasing _service file complexity in OBS.

Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany force-pushed the drop_slemicro_version_references_from_code branch from 393f8a7 to 812c1c7 Compare July 31, 2023 20:48
@davidcassany davidcassany marked this pull request as ready for review July 31, 2023 20:48
@davidcassany
Copy link
Contributor Author

Looks much better now laughing

I ended up keeping the latest tag and the sle micro version as part of the image repository in registry. We need the latest tag for testing, it will be painful without it, it is just so handy for testing dev. As a counter part I made the sle micro version string dynamic with further _service tricks

@kkaempf kkaempf added this to the Teal 5.4 milestone Aug 1, 2023
@davidcassany davidcassany merged commit 40b6630 into rancher:main Aug 1, 2023
7 checks passed
@davidcassany davidcassany deleted the drop_slemicro_version_references_from_code branch August 1, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkaempf kkaempf kkaempf approved these changes

@fgiudici fgiudici fgiudici approved these changes

Assignees
No one assigned
Labels
kind/chore
Projects
Elemental
Archived in project
Milestone
Teal 5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@davidcassany @kkaempf @fgiudici