Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elemental Cypress code review/cleanup #893

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Elemental Cypress code review/cleanup #893

merged 2 commits into from
Jul 4, 2023

Conversation

juadk
Copy link
Contributor

@juadk juadk commented Jul 4, 2023 •
edited
Loading

  • Remove older Cypress code specific to 1.0.0
  • Improve code according to vscode typescript warnings

UI-K3s-Rancher_Stable ✔️
UI-RKE2-Rancher_Stable ✔️

UI-K3s-OS-Upgrade-Rancher_Stable ✔️
UI-RKE2-OS-Upgrade-Rancher_Stable ❌ (failed due to external reason of this PR)

@juadk juadk marked this pull request as ready for review July 4, 2023 09:24
@juadk juadk requested a review from a team as a code owner July 4, 2023 09:24
@juadk juadk added the kind/QA label Jul 4, 2023
@juadk juadk self-assigned this Jul 4, 2023
ldevulder
ldevulder approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@ldevulder ldevulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! LGTM!

@juadk juadk merged commit cfca315 into main Jul 4, 2023
16 of 17 checks passed
@juadk juadk deleted the coding_style_review branch July 4, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldevulder ldevulder ldevulder approved these changes

Assignees

@juadk juadk

Labels
kind/QA
Projects
Elemental
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juadk @ldevulder