Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use WaitForNamespaceWithPod function #866

Merged
merged 1 commit into from
Jun 9, 2023
Merged

ci: use WaitForNamespaceWithPod function #866

merged 1 commit into from
Jun 9, 2023

Conversation

ldevulder
Copy link
Contributor

@ldevulder ldevulder commented Jun 9, 2023 •
edited
Loading

Use WaitForNamespaceWithPod function instead of WaitForPod to ensure that the pods are running.

Verification runs:

@ldevulder ldevulder requested a review from a team as a code owner June 9, 2023 10:53
@ldevulder ldevulder self-assigned this Jun 9, 2023
@ldevulder ldevulder marked this pull request as draft June 9, 2023 10:53
@ldevulder
ci: use WaitForNamespaceWithPod function
f83ae3f 
Use WaitForNamespaceWithPod function instead of WaitForPod to ensure
that the pods are running.

Signed-off-by: Loic Devulder <ldevulder@suse.com>
@ldevulder ldevulder force-pushed the ci-use-waitfornamespacewithpod-function branch from 9c4b287 to f83ae3f Compare June 9, 2023 11:14
@ldevulder ldevulder marked this pull request as ready for review June 9, 2023 12:55
frelon
frelon approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@frelon frelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fgiudici
fgiudici approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good here!

@ldevulder ldevulder merged commit 4eff2ef into main Jun 9, 2023
@ldevulder ldevulder deleted the ci-use-waitfornamespacewithpod-function branch June 9, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frelon frelon frelon approved these changes

@fgiudici fgiudici fgiudici approved these changes

Assignees

@ldevulder ldevulder

Labels
kind/QA
Projects
Elemental
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldevulder @frelon @fgiudici