Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use rancher head version instead of rc version #853

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

juadk
Copy link
Contributor

@juadk juadk commented Jun 1, 2023

Fix #720

In the CI, we don't really test latest rancher version but release candidate version.
It could be better to test latest updates, that's why we want to test v2.7-head by default.

Older behavior

When we set rancherVersion to latest/devel, it installed latest rc version.

New behavior

With rancherVersion equal to latest/devel, we install the head version (by default)
With rancherVersion equal to latest/2.7.5-rc3, we install 2.7.5 release candidate 3

PS: The head version is hardcoded but I don't know if we can make it better without adding a new variable, could be improve later.

Verification runs

  containers:
  - args:
    - --http-listen-port=80
    - --https-listen-port=443
    - --add-local=true
    env:
    - name: CATTLE_NAMESPACE
      value: cattle-system
    - name: CATTLE_PEER_SERVICE
      value: rancher
    - name: CATTLE_SERVER_URL
      value: https://84.203.173.34.bc.googleusercontent.com
    - name: CATTLE_BOOTSTRAP_PASSWORD
      value: rancherpassword
    image: rancher/rancher:v2.7.5-rc3

UI-K3s-Rancher_Latest: failed because there is a login issue with v2.7.5-rc3 but the logic is ok.

  containers:
  - args:
    - --http-listen-port=80
    - --https-listen-port=443
    - --add-local=true
    env:
    - name: CATTLE_NAMESPACE
      value: cattle-system
    - name: CATTLE_PEER_SERVICE
      value: rancher
    - name: CATTLE_SERVER_URL
      value: https://64.144.192.35.bc.googleusercontent.com
    - name: CATTLE_BOOTSTRAP_PASSWORD
      value: rancherpassword
    image: rancher/rancher:v2.7-head

UI-K3s-Rancher_Latest: we can see that v2.7-head was used.

@juadk juadk self-assigned this Jun 1, 2023
@juadk juadk force-pushed the 720-use_rancher_head_version branch from 3d39f6b to 604a719 Compare June 1, 2023 08:43
@juadk juadk marked this pull request as ready for review June 1, 2023 09:19
@juadk juadk requested a review from a team as a code owner June 1, 2023 09:19
@juadk juadk added the kind/QA label Jun 1, 2023
@juadk juadk force-pushed the 720-use_rancher_head_version branch from 604a719 to ccda9a3 Compare June 1, 2023 09:47
@juadk juadk merged commit 4d9cfa6 into main Jun 5, 2023
@juadk juadk deleted the 720-use_rancher_head_version branch June 5, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

e2e: Use rancher manager head version instead of RC versions
2 participants