Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add containerized ISO image #797

Merged
merged 1 commit into from
May 2, 2023

Conversation

davidcassany
Copy link
Contributor

This is the Dockerfile to build the ISO as a container. It is a natural evolution of the build-iso package in OBS and build-iso should simply pull this Dockerfile from github. This way the image OS and its ISO are both defined and described within the same place.

Part of to rancher/elemental-operator#396

@kkaempf
Copy link
Contributor

kkaempf commented Apr 20, 2023

There are three occurences of 5.3 in the Dockerfile. Can these be a parameter ?

Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@davidcassany
Copy link
Contributor Author

There are three occurences of 5.3 in the Dockerfile. Can these be a parameter ?

Yes it can, it just goes at the cost of making our already complex _service file bigger. Ideally we should be capable to pull it from the prjconf so we could build with same sources for 5.3 and 5.4 in different repositories. Doable, the problem is that this means adding another twist in _service files and in prjconf. We can/should consider it though.

Probably we can make it a new issue for building against 5.4 from same sources, to we do not have to maintain to projects, just create the appropriate repos in OBS.

Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany merged commit c168f8f into rancher:main May 2, 2023
@davidcassany davidcassany deleted the add_iso_container_image branch May 2, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants