Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/e2e: test emulated TPM on more than one node #622

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

ldevulder
Copy link
Contributor

@ldevulder ldevulder commented Jan 19, 2023

As emulated TPM now works on more than one node, the seed is generated based on the server UUID.

This should fix #586.

Verification run:

@ldevulder ldevulder self-assigned this Jan 19, 2023
@ldevulder ldevulder marked this pull request as draft January 19, 2023 16:45
@ldevulder ldevulder force-pushed the e2e-test-new-emulated-tpm branch 3 times, most recently from f431c3e to f918728 Compare January 19, 2023 17:54
As emulated TPM now works on more than one node, the seed is generated
based on the server UUID.

Signed-off-by: Loic Devulder <ldevulder@suse.com>
As recent version of virt-manager enable TPM device by default even if
it is not set.

Signed-off-by: Loic Devulder <ldevulder@suse.com>
@ldevulder ldevulder force-pushed the e2e-test-new-emulated-tpm branch 2 times, most recently from 05f2269 to 284fa4d Compare January 23, 2023 08:00
@ldevulder ldevulder marked this pull request as ready for review January 23, 2023 08:51
@ldevulder ldevulder enabled auto-merge (rebase) January 23, 2023 09:11
Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ldevulder ldevulder merged commit 6fd008b into main Jan 23, 2023
@ldevulder ldevulder deleted the e2e-test-new-emulated-tpm branch January 23, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

e2e: test new autogenerated seed for emulated TPM
2 participants