Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop docs/ and examples/ directories #593

Merged
merged 2 commits into from
Dec 27, 2022

Conversation

kkaempf
Copy link
Contributor

@kkaempf kkaempf commented Dec 23, 2022

Everything is in https://github.com/rancher/elemental-docs/ now

Signed-off-by: Klaus Kämpf kkaempf@suse.de

Everything is in https://github.com/rancher/elemental-docs/ now

Signed-off-by: Klaus Kämpf <kkaempf@suse.de>
@kkaempf
Copy link
Contributor Author

kkaempf commented Dec 23, 2022

See also rancher/elemental-docs#28

Copy link
Contributor

@mjura mjura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that CI needs to be adjusted also

Error:  Unable to build website for locale en.
21
Error:  Error: The docs folder does not exist for version "current". A docs folder is expected to be found at docs.

Copy link
Contributor

@juadk juadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was doing the same for configuration files, could you also remove these files please? (I just synced with Nuno about that):

.github/workflows/docs.yaml
Vars.js
babel.config.js
docusaurus.config.js
sidebars.js
yarn.lock
src
static

I will take care about removing the unused dependencies in the package.json in a separate PR.

Signed-off-by: Klaus Kämpf <kkaempf@suse.de>
@kkaempf
Copy link
Contributor Author

kkaempf commented Dec 27, 2022

I was doing the same for configuration files, could you also remove these files please? (I just synced with Nuno about that):

.github/workflows/docs.yaml
Vars.js
babel.config.js
docusaurus.config.js
sidebars.js
yarn.lock
src
static

Done.

I will take care about removing the unused dependencies in the package.json in a separate PR.

Thanks !

Copy link
Contributor

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11000 lines removed? yes please.

@kkaempf kkaempf merged commit 32fb97a into rancher:main Dec 27, 2022
@kkaempf kkaempf deleted the drop-docs-and-examples branch December 27, 2022 11:46
@ldevulder
Copy link
Contributor

I will take care about removing the unused dependencies in the package.json in a separate PR.

Done in PR #591.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants