Use machine reg created in UI instead of the one in test assets #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juadk
force-pushed
the
use_machine_registration_from_ui
branch
3 times, most recently
from
1ad812b
to
4c6c2f6
Compare
juadk
force-pushed
the
use_machine_registration_from_ui
branch
from
4c6c2f6
to
1b052c6
Compare
ldevulder
requested changes
Nov 9, 2022
juadk
force-pushed
the
use_machine_registration_from_ui
branch
from
f3e8a00
to
fae48b9
Compare
ldevulder
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug with cloud-config, until now, we were using a machine registration not created in the UI but the same as the backend e2e test (https://github.com/rancher/elemental/blob/main/tests/assets/machineregistration.yaml).
It sound more logical to run the test with a machine registration created with the UI.
This PR adds a test in machine registration to create the resource we need to deploy a node.
Actually, it also tests the cloud config block because we have to import our custom cloud config there.
Fix #215
Verification run:
https://github.com/rancher/elemental/actions/runs/3427858809