Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/qase: some fixes and improvements with qase/ginkgo integration #1176

Merged
merged 6 commits into from
Jan 23, 2024

Conversation

ldevulder
Copy link
Contributor

@ldevulder ldevulder commented Jan 22, 2024

It is not very useful to keep Qase run/report when a job/workflow has been canceled, as the run will never be completed and more over we could have all cases green in the report and some missing so the whole report will be green and that's not the real status of the test.
It is also better to publish the whole test result at the end of the test.

List of all fixes:

  • qase/lib: fix some checks
  • ci: add GH test run URL in Qase result
  • ci: publish and complete Qase Run outside of Ginkgo
  • ci: delete Qase Run if job has been cancelled
  • qase/lib: update README
  • qase/lib: remove QASE_DELETE_RUN support

Verification runs:

NOTE: 2nd VR failed for another issue, not related to this PR.

@ldevulder ldevulder self-assigned this Jan 22, 2024
@ldevulder ldevulder requested a review from a team as a code owner January 22, 2024 16:02
@ldevulder ldevulder marked this pull request as draft January 22, 2024 16:03
@ldevulder ldevulder force-pushed the delete-cancelled-gh-jobs-in-qase branch 2 times, most recently from 8dd523e to 6ec3b98 Compare January 22, 2024 16:07
@ldevulder ldevulder changed the title ci: delete Qase Run if job has been cancelled [WIP] ci: delete Qase Run if job has been cancelled Jan 22, 2024
As it's not very useful, was more for debugging purposes at the
beginning.

Signed-off-by: Loic Devulder <ldevulder@suse.com>
@ldevulder ldevulder force-pushed the delete-cancelled-gh-jobs-in-qase branch from 6ec3b98 to 5392ccd Compare January 23, 2024 09:12
Signed-off-by: Loic Devulder <ldevulder@suse.com>
@ldevulder ldevulder force-pushed the delete-cancelled-gh-jobs-in-qase branch from 5392ccd to 94da951 Compare January 23, 2024 10:48
@ldevulder ldevulder changed the title [WIP] ci: delete Qase Run if job has been cancelled ci/qase: some fixes and improvements with qase/ginkgo integration Jan 23, 2024
@ldevulder ldevulder force-pushed the delete-cancelled-gh-jobs-in-qase branch from 7eb03e6 to 9f71935 Compare January 23, 2024 12:09
@ldevulder ldevulder marked this pull request as ready for review January 23, 2024 12:23
@ldevulder ldevulder force-pushed the delete-cancelled-gh-jobs-in-qase branch from 9f71935 to 9aede4f Compare January 23, 2024 12:26
Signed-off-by: Loic Devulder <ldevulder@suse.com>
@ldevulder ldevulder force-pushed the delete-cancelled-gh-jobs-in-qase branch from 9aede4f to b3a1a49 Compare January 23, 2024 12:45
tests/qase/qase_cmd.go Outdated Show resolved Hide resolved
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
Signed-off-by: Loic Devulder <ldevulder@suse.com>
@ldevulder ldevulder force-pushed the delete-cancelled-gh-jobs-in-qase branch from b3a1a49 to 49290ca Compare January 23, 2024 12:50
@ldevulder ldevulder merged commit c2451ff into main Jan 23, 2024
14 of 16 checks passed
@ldevulder ldevulder deleted the delete-cancelled-gh-jobs-in-qase branch January 23, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants