Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use per-flavor Dockerfiles #1167

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

kkaempf
Copy link
Contributor

@kkaempf kkaempf commented Jan 12, 2024

This reverts the single, flavored Dockerfile to many, per-flavor ones.

Turns out that build service gets confused with multiple (intended to be per-flavor) zypper calls and lumps them all into one trying to resolve dependencies.

This fails e.g. with the 'standard' image (trying to install multipath-tools) combined with the kvm image (trying to replace kernel-default with kernel-default-base), leading to multipath-tools being uninstallable (because it needs kernel-default and can't work with kernel-default-base).

Signed-off-by: Klaus Kämpf <kkaempf@suse.de>
@kkaempf kkaempf requested a review from a team as a code owner January 12, 2024 16:37
@kkaempf kkaempf added this to the slem-5.5 milestone Jan 12, 2024
@kkaempf kkaempf added the kind/bug Something isn't working label Jan 12, 2024
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails e.g. with the 'standard' image (trying to install multipath-tools) combined with the kvm image (trying to replace kernel-default with kernel-default-base), leading to multipath-tools being uninstallable (because it needs kernel-default and can't work with kernel-default-base).

ouch 🤦🏽‍♂️

Yes the flavors would be really cool, but there are too many rocks in the path. They are far from smooth and the setup turn to be way too convoluted to make real use of them... I fully agree on splitting all in different Dockerfiles. Later on we can revisit building all them in a single OBS package but using individual dockerfiles, we could do this by improving a little the OBS buildtime services. But that for later.

@kkaempf kkaempf merged commit 7f0f8af into rancher:main Jan 15, 2024
11 checks passed
@kkaempf kkaempf deleted the per-flavor-dockerfiles branch January 15, 2024 14:15
@kkaempf
Copy link
Contributor Author

kkaempf commented Jan 15, 2024

/backport v2.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants