Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.9] - Fix reference to tsc binary when publishing shell #12190

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

jordojordo
Copy link
Member

Summary

Fixes #12187

The node_modules/.bin is no longer accessible due to a typo within the BASE_DIR variable

Occurred changes and/or fixed issues

  • Replaced the single & with a double && in both publish-shell.sh and typegen.sh scripts
  • Added pipefail to publish-shell script to ensure it will exit when a command has an error

Technical notes summary

Using a single ampersand & instead of a double ampersand && will run the preceding command in the background rather than sequentially.

Areas or cases that should be tested

  • Publishing of shell packages

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

jordojordo and others added 2 commits October 9, 2024 11:46
* Fix BASE_DIR path

* Add pipefail for proper error handling
@jordojordo jordojordo added this to the v2.9.3 milestone Oct 9, 2024
@jordojordo jordojordo self-assigned this Oct 9, 2024
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordojordo jordojordo merged commit 2cf6b64 into rancher:release-2.9 Oct 10, 2024
26 checks passed
@jordojordo jordojordo deleted the 12176-backport-2.9 branch October 10, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants