Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the vertical scroll bar on setup page is flush with graphic #12144

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Oct 4, 2024

Summary

Fixes: #12145

Occurred changes and/or fixed issues

  • See screenshots
    • scroll bar flush with graphic
    • give more room for form
  • Held off doing this as there was a PR that totally changed the whole setup / login page flow, however i think that's now DOA
  • So this is a quick fix for a long time annoyance

Technical notes summary

  • The file is a mess of styles, will need tidying up one day

Areas or cases that should be tested

  • setup pages
  • loign pages (just in case)

Screenshot/Video

Before
image

After
image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox richard-cox added this to the v2.10.0 milestone Oct 4, 2024
@richard-cox richard-cox self-assigned this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Page: Scroll bar is floating
1 participant