Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ingress Rule Path CSS #12012

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Conversation

cnotv
Copy link
Contributor

@cnotv cnotv commented Sep 24, 2024

Summary

Fixes #12011

Although I have not been able to reproduce a case where the definition breaks (https://codesandbox.io/p/sandbox/yy4cgk), this PR addresses the styling issue by correcting the :deep() definition got lost during the migration.

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Navigate to Ingress edit > Rule path (e.g.: /c/local/explorer/networking.k8s.io.ingress/create#rules

Areas which could experience regressions

Screenshot/Video

Screenshot 2024-09-23 at 18 05 46

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@cnotv cnotv force-pushed the feature/12011-ingress-rule-path branch from d2d7eb1 to f53f8f2 Compare September 24, 2024 21:25
rak-phillip
rak-phillip previously approved these changes Sep 24, 2024
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'm only noticing a minor spacing difference in 2.10 vs 2.9. We might want to figure it out if we intend for this to be a 1:1 match with what we had before.

v2.10

image

v2.9

image

shell/edit/networking.k8s.io.ingress/RulePath.vue Outdated Show resolved Hide resolved
@cnotv
Copy link
Contributor Author

cnotv commented Sep 25, 2024

Wait why do you see it like this? It should not have gaps. Is it with Firefox?

@rak-phillip
Copy link
Member

Wait why do you see it like this? It should not have gaps. Is it with Firefox?

That's correct, I'm on Firefox. I'm willing to bet that this might have been an unintentional rendering bug that was left unreported.

@cnotv
Copy link
Contributor Author

cnotv commented Sep 27, 2024

Wait why do you see it like this? It should not have gaps. Is it with Firefox?

That's correct, I'm on Firefox. I'm willing to bet that this might have been an unintentional rendering bug that was left unreported.

This is how it looks for me on FF 130.0 (64-bit)
Screenshot 2024-09-27 at 14 32 07

@cnotv
Copy link
Contributor Author

cnotv commented Sep 27, 2024

Wait why do you see it like this? It should not have gaps. Is it with Firefox?

That's correct, I'm on Firefox. I'm willing to bet that this might have been an unintentional rendering bug that was left unreported.

Ok found out the issue: it's the UI to is not responsive, the same problem happens on Chrome. We probably are full of these types of issues which we are not going to tackle now.

@cnotv cnotv merged commit 0a773ca into rancher:master Oct 4, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingress Rule Path input not displayed correctly
2 participants