Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensions compatibility tests 2.10 #11508

Merged
merged 59 commits into from
Aug 15, 2024
Merged

Extensions compatibility tests 2.10 #11508

merged 59 commits into from
Aug 15, 2024

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Jul 23, 2024 •
edited
Loading

Summary

Fixes #11482

Occurred changes and/or fixed issues

  • Adds cron-job triggered workflow to run extensions e2e tests against 2.10 and 2.9 systems (for now only elemental spec is complete)
  • update some scripts in order to pass needed variables to key areas of the workflow
  • introduce the --spec argument to run only needed specs as grep tags aren't working properly
  • Adds tests for the Elemental extension

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 force-pushed the 11482-extensions-compatibility-tests branch from 8dc087f to 887d38d Compare July 24, 2024 14:10
@aalves08 aalves08 changed the title saving WIP Extensions compatibility tests Jul 24, 2024
@aalves08 aalves08 changed the title Extensions compatibility tests WIP: Extensions compatibility tests 2.9 + head Jul 26, 2024
@aalves08 aalves08 changed the title WIP: Extensions compatibility tests 2.9 + head Extensions compatibility tests 2.9 + head Jul 26, 2024
@aalves08 aalves08 force-pushed the 11482-extensions-compatibility-tests branch from 46989f9 to 4cd3724 Compare July 31, 2024 10:14
@aalves08 aalves08 changed the base branch from master to release-2.9 July 31, 2024 15:13
@aalves08 aalves08 changed the base branch from release-2.9 to master July 31, 2024 15:14
@aalves08 aalves08 changed the title Extensions compatibility tests 2.9 + head Extensions compatibility tests 2.10 Aug 1, 2024
@aalves08 aalves08 mentioned this pull request Aug 2, 2024
Open
10 tasks
@aalves08 aalves08 force-pushed the 11482-extensions-compatibility-tests branch from d1176b0 to 0413875 Compare August 2, 2024 13:57
@aalves08 aalves08 added this to the v2.10.0 milestone Aug 9, 2024
@aalves08 aalves08 marked this pull request as ready for review August 9, 2024 10:35
richard-cox
richard-cox requested changes Aug 13, 2024
View reviewed changes
.github/workflows/extensions-compatibility-tests.yaml Outdated Show resolved Hide resolved
cypress/e2e/po/pages/extensions-compatibility-tests/elemental.po.ts Outdated Show resolved Hide resolved
cypress/e2e/po/pages/extensions-compatibility-tests/extensions-compatibility.po.ts Outdated Show resolved Hide resolved
cypress/e2e/po/pages/extensions-compatibility-tests/extensions-compatibility.po.ts Outdated Show resolved Hide resolved
cypress/e2e/po/pages/extensions-compatibility-tests/extensions-compatibility.po.ts Outdated Show resolved Hide resolved
cypress/e2e/tests/pages/extensions-compatibility-tests/elemental.spec.ts Outdated
import * as jsyaml from 'js-yaml';

const EXTENSION_NAME = 'elemental';
const EXTENSION_VERSION = '2.0.0-rc2';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to manually bump this every time. shouldn't we stick to latest?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we define latest since it's a fixed version number?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we would pick the first / top entry in the list (assuming versions are sorted)

cypress/e2e/tests/pages/extensions-compatibility-tests/elemental.spec.ts Outdated Show resolved Hide resolved
cypress/e2e/tests/pages/extensions-compatibility-tests/elemental.spec.ts Outdated Show resolved Hide resolved
cypress/e2e/tests/pages/extensions-compatibility-tests/kubewarden.spec.ts Outdated Show resolved Hide resolved
@aalves08 aalves08 force-pushed the 11482-extensions-compatibility-tests branch from d463310 to c468288 Compare August 14, 2024 08:10
@aalves08 aalves08 force-pushed the 11482-extensions-compatibility-tests branch from c468288 to c006f3d Compare August 14, 2024 08:11
richard-cox
richard-cox requested changes Aug 14, 2024
View reviewed changes
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment remaining, plus e2e tests re-enabled

When doing the refactor i noticed sometimes after adding the elemental repo the extension failed to show in the Available extension tab. Might be local env, or be flacky when running nightly. Sometime to keep your eye on

@aalves08
Copy link
Member Author

Just one comment remaining, plus e2e tests re-enabled

When doing the refactor i noticed sometimes after adding the elemental repo the extension failed to show in the Available extension tab. Might be local env, or be flacky when running nightly. Sometime to keep your eye on

It should wait for the repo to be available and synced but I've added a wait just to give it a time buffer... I don't have another technical way besides tracking the active state in addExtensionsRepositoryDirectLink method

@richard-cox richard-cox merged commit 5ee4809 into rancher:master Aug 15, 2024
28 checks passed
@aalves08 aalves08 mentioned this pull request Aug 19, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-cox richard-cox richard-cox approved these changes

@nwmac nwmac Awaiting requested review from nwmac

Assignees

@aalves08 aalves08

Labels
None yet
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.

Extensions: Vue 3 extension validation and compatibility
2 participants
@aalves08 @richard-cox