Support arbitrary CLI options #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es we don't know about) to themes. They can use these for theme specific things like logo paths.
|
This would work for me. |
|
Yeah I think that just comes down to readme files for now at least.
… On 9 Mar 2017, at 12:25, wdullaer ***@***.***> wrote:
This would work for me.
The only thing that's missing is a way to make the theme options discoverable.
That said, I don't have an immediate solution for that, at least not one which requires rewriting big chunks of the cli.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
…cally format all code. Called via ESLint so we benifit from the great exising editor integrations, files get formatted on save. Biggest reason to use this vs the old AirBnb style? Less config, no longer need to worry about code style, just let the tool handle all formatting. For developers nothing really changes: still run `npm run lint` to lint (and now auto format) all JS files.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass all CLI options (even ones we don't know about) to themes. They can use these for theme specific things like logo paths.
Needed for wdullaer/raml2slate#3 for example.
Reason from switching away from Commander: tj/commander.js#609