Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default Error status code to 404 (#6276) #61

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Set default Error status code to 404 (#6276) #61

merged 1 commit into from
Feb 13, 2019

Commits on Feb 13, 2019

  1. Set default Error status code to 404 (#6276) 

    * Set default `Error` status code to 404

This is an appropriate default behavior because:

1. When the server encounters an error, the `err` property is set.
2. When the client-side application crashes, the `err` property is set.

This means the "only" way to render the `/_error` page without an error
is when a page is not found (special condition).

Fixes #6243
Closes #5437

* Add new integration test for client side 404

* single quotes

* Remove unused variable

* Standard needs to go away

* Whoops

* Check for null status code in res and err

* Only check response for valid statusCode
    @Timer
    Timer committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    f43e1a9 View commit details
    Browse the repository at this point in the history