Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency celery to v5.4.0 #16

Merged
merged 9 commits into from
May 11, 2024

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented May 11, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
celery (source, changelog) ==5.2.7 -> ==5.4.0 age adoption passing confidence

Release Notes

celery/celery (celery)

v5.4.0

Compare Source

=====

:release-date: 2024-04-17
:release-by: Tomer Nosrati

Celery v5.4.0 and v5.3.x have consistently focused on enhancing the overall QA, both internally and externally.
This effort led to the new pytest-celery v1.0.0 release, developed concurrently with v5.3.0 & v5.4.0.

This release introduces two significant QA enhancements:

  • Smoke Tests: A new layer of automatic tests has been added to Celery's standard CI. These tests are designed to handle production scenarios and complex conditions efficiently. While new contributions will not be halted due to the lack of smoke tests, we will request smoke tests for advanced changes where appropriate.
  • Standalone Bug Report Script <https://docs.celeryq.dev/projects/pytest-celery/en/latest/userguide/celery-bug-report.html>_: The new pytest-celery plugin now allows for encapsulating a complete Celery dockerized setup within a single pytest script. Incorporating these into new bug reports will enable us to reproduce reported bugs deterministically, potentially speeding up the resolution process.

Contrary to the positive developments above, there have been numerous reports about issues with the Redis broker malfunctioning
upon restarts and disconnections. Our initial attempts to resolve this were not successful (#​8796).
With our enhanced QA capabilities, we are now prepared to address the core issue with Redis (as a broker) again.

The rest of the changes for this release are grouped below, with the changes from the latest release candidate listed at the end.

Changes

  • Add a Task class specialised for Django (#​8491)
  • Add Google Cloud Storage (GCS) backend (#​8868)
  • Added documentation to the smoke tests infra (#​8970)
  • Added a checklist item for using pytest-celery in a bug report (#​8971)
  • Bugfix: Missing id on chain (#​8798)
  • Bugfix: Worker not consuming tasks after Redis broker restart (#​8796)
  • Catch UnicodeDecodeError when opening corrupt beat-schedule.db (#​8806)
  • chore(ci): Enhance CI with workflow_dispatch for targeted debugging and testing (#​8826)
  • Doc: Enhance "Testing with Celery" section (#​8955)
  • Docfix: pip install celery[sqs] -> pip install "celery[sqs]" (#​8829)
  • Enable efficient chord when using dynamicdb as backend store (#​8783)
  • feat(daemon): allows daemonization options to be fetched from app settings (#​8553)
  • Fix DeprecationWarning: datetime.datetime.utcnow() (#​8726)
  • Fix recursive result parents on group in middle of chain (#​8903)
  • Fix typos and grammar (#​8915)
  • Fixed version documentation tag from #​8553 in configuration.rst (#​8802)
  • Hotfix: Smoke tests didn't allow customizing the worker's command arguments, now it does (#​8937)
  • Make custom remote control commands available in CLI (#​8489)
  • Print safe_say() to stdout for non-error flows (#​8919)
  • Support moto 5.0 (#​8838)
  • Update contributing guide to use ssh upstream url (#​8881)
  • Update optimizing.rst (#​8945)
  • Updated concurrency docs page. (#​8753)

Dependencies Updates

  • Bump actions/setup-python from 4 to 5 (#​8701)
  • Bump codecov/codecov-action from 3 to 4 (#​8831)
  • Bump isort from 5.12.0 to 5.13.2 (#​8772)
  • Bump msgpack from 1.0.7 to 1.0.8 (#​8885)
  • Bump mypy from 1.8.0 to 1.9.0 (#​8898)
  • Bump pre-commit to 3.6.1 (#​8839)
  • Bump pre-commit/action from 3.0.0 to 3.0.1 (#​8835)
  • Bump pytest from 8.0.2 to 8.1.1 (#​8901)
  • Bump pytest-celery to v1.0.0 (#​8962)
  • Bump pytest-cov to 5.0.0 (#​8924)
  • Bump pytest-order from 1.2.0 to 1.2.1 (#​8941)
  • Bump pytest-subtests from 0.11.0 to 0.12.1 (#​8896)
  • Bump pytest-timeout from 2.2.0 to 2.3.1 (#​8894)
  • Bump python-memcached from 1.59 to 1.61 (#​8776)
  • Bump sphinx-click from 4.4.0 to 5.1.0 (#​8774)
  • Update cryptography to 42.0.5 (#​8869)
  • Update elastic-transport requirement from <=8.12.0 to <=8.13.0 (#​8933)
  • Update elasticsearch requirement from <=8.12.1 to <=8.13.0 (#​8934)
  • Upgraded Sphinx from v5.3.0 to v7.x.x (#​8803)

Changes since 5.4.0rc2

  • Update elastic-transport requirement from <=8.12.0 to <=8.13.0 (#​8933)
  • Update elasticsearch requirement from <=8.12.1 to <=8.13.0 (#​8934)
  • Hotfix: Smoke tests didn't allow customizing the worker's command arguments, now it does (#​8937)
  • Bump pytest-celery to 1.0.0rc3 (#​8946)
  • Update optimizing.rst (#​8945)
  • Doc: Enhance "Testing with Celery" section (#​8955)
  • Bump pytest-celery to v1.0.0 (#​8962)
  • Bump pytest-order from 1.2.0 to 1.2.1 (#​8941)
  • Added documentation to the smoke tests infra (#​8970)
  • Added a checklist item for using pytest-celery in a bug report (#​8971)

.. _version-5.4.0rc2:

v5.3.6

Compare Source

=====

:release-date: 2023-11-22 9:15 P.M GMT+6
:release-by: Asif Saif Uddin

This release is focused mainly to fix AWS SQS new feature comatibility issue and old regressions.
The code changes are mostly fix for regressions. More details can be found below.

v5.3.5

Compare Source

=====

:release-date: 2023-11-10 7:15 P.M GMT+6
:release-by: Asif Saif Uddin

v5.3.4

Compare Source

=====

:release-date: 2023-09-03 10:10 P.M GMT+2
:release-by: Tomer Nosrati

.. warning::
This version has reverted the breaking changes introduced in 5.3.2 and 5.3.3:

  • Revert "store children with database backend" (#​8475)

  • Revert "Fix eager tasks does not populate name field" (#​8476)

  • Bugfix: Removed unecessary stamping code from _chord.run() (#​8339)

  • User guide fix (hotfix for #​1755) (#​8342)

  • store children with database backend (#​8338)

  • Stamping bugfix with group/chord header errback linking (#​8347)

  • Use argsrepr and kwargsrepr in LOG_RECEIVED (#​8301)

  • Fixing minor typo in code example in calling.rst (#​8366)

  • add documents for timeout settings (#​8373)

  • fix: copyright year (#​8380)

  • setup.py: enable include_package_data (#​8379)

  • Fix eager tasks does not populate name field (#​8383)

  • Update test.txt dependencies (#​8389)

  • Update auth.txt deps (#​8392)

  • Fix backend.get_task_meta ignores the result_extended config parameter in mongodb backend (#​8391)

  • Support preload options for shell and purge commands (#​8374)

  • Implement safer ArangoDB queries (#​8351)

  • integration test: cleanup worker after test case (#​8361)

  • Added "Tomer Nosrati" to CONTRIBUTORS.txt (#​8400)

  • Update README.rst (#​8404)

  • Update README.rst (#​8408)

  • fix(canvas): add group index when unrolling tasks (#​8427)

  • fix(beat): debug statement should only log AsyncResult.id if it exists (#​8428)

  • Lint fixes & pre-commit autoupdate (#​8414)

  • Update auth.txt (#​8435)

  • Update mypy on test.txt (#​8438)

  • added missing kwargs arguments in some cli cmd (#​8049)

  • Fix #​8431: Set format_date to False when calling _get_result_meta on mongo backend (#​8432)

  • Docs: rewrite out-of-date code (#​8441)

  • Limit redis client to 4.x since 5.x fails the test suite (#​8442)

  • Limit tox to < 4.9 (#​8443)

  • Fixed issue: Flags broker_connection_retry_on_startup & broker_connection_retry aren’t reliable (#​8446)

  • doc update from #​7651 (#​8451)

  • Remove tox version limit (#​8464)

  • Fixed AttributeError: 'str' object has no attribute (#​8463)

  • Upgraded Kombu from 5.3.1 -> 5.3.2 (#​8468)

  • Document need for CELERY_ prefix on CLI env vars (#​8469)

  • Use string value for CELERY_SKIP_CHECKS envvar (#​8462)

  • Revert "store children with database backend" (#​8475)

  • Revert "Fix eager tasks does not populate name field" (#​8476)

  • Update Changelog (#​8474)

  • Remove as it seems to be buggy. (#​8340)

  • Revert "Add Semgrep to CI" (#​8477)

  • Revert "Revert "Add Semgrep to CI"" (#​8478)

.. _version-5.3.3:

v5.3.1

Compare Source

=====

:release-date: 2023-06-18 8:15 P.M GMT+6
:release-by: Asif Saif Uddin

  • Upgrade to latest pycurl release (#​7069).
  • Limit librabbitmq>=2.0.0; python_version < '3.11' (#​8302).
  • Added initial support for python 3.11 (#​8304).
  • ChainMap observers fix (#​8305).
  • Revert optimization CLI flag behaviour back to original.
  • Restrict redis 4.5.5 as it has severe bugs (#​8317).
  • Tested pypy 3.10 version in CI (#​8320).
  • Bump new version of kombu to 5.3.1 (#​8323).
  • Fixed a small float value of retry_backoff (#​8295).
  • Limit pyro4 up to python 3.10 only as it is (#​8324).

.. _version-5.3.0:

v5.3.0

Compare Source

=====

:release-date: 2023-06-06 12:00 P.M GMT+6
:release-by: Asif Saif Uddin

  • Test kombu 5.3.0 & minor doc update (#​8294).
  • Update librabbitmq.txt > 2.0.0 (#​8292).
  • Upgrade syntax to py3.8 (#​8281).

.. _version-5.3.0rc2:


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Summary by CodeRabbit

  • New Features

    • Added a new GitHub Actions workflow for automated testing on the api directory.
    • Introduced a configuration for the Python Debugger with Django support in Visual Studio Code.
    • Updated the local development environment setup instructions for a Python project using Visual Studio Code and Django.
    • Added a new pgadmin service in the Docker environment for database management.
  • Documentation

    • Provided comprehensive setup and running instructions in the new api/ReadMe.md.
  • Updates

    • Upgraded the celery library from version 5.2.7 to 5.4.0.
    • Updated the timescaledb image to the latest version supporting PostgreSQL 16.

Copy link

coderabbitai bot commented May 11, 2024

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This update introduces a new GitHub Actions workflow for the api directory, enhances debugging capabilities in Visual Studio Code for Django, updates dependency versions in requirements.txt, and modifies the docker-compose.yml to include a new service and update existing configurations. These changes aim to improve development efficiency and maintain up-to-date technology stacks.

Changes

File Path Change Summary
.github/workflows/... Introduced a new workflow for running tests in the api directory.
.vscode/launch.json Updated to support Python Debugger with Django.
api/ReadMe.md Added instructions for setting up a local dev environment using VS Code and Django.
api/requirements.txt Updated celery from 5.2.7 to 5.4.0.
docker-compose.yml Updated timescaledb to latest-pg16 and added pgadmin service with configuration and exposed port 5050.

🐇✨
In the garden of code, where the data trees grow,
New actions take root, and the workflows flow.
With a hop and a skip, updates come alive,
Debugging by moon, on port fifty-five.
Cheers to the crew, with each line we compose,
In the burrow of bytes, where the wild celery grows!
🌟🐰


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Author

renovate bot commented May 11, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@rajadilipkolli
Copy link
Owner

@coderabbitai review

Copy link

coderabbitai bot commented May 11, 2024

Actions Performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 3477e09 and 2f85cc7.
Files selected for processing (5)
  • .github/workflows/api.yml (1 hunks)
  • .vscode/launch.json (1 hunks)
  • api/ReadMe.md (1 hunks)
  • api/requirements.txt (1 hunks)
  • docker-compose.yml (2 hunks)
Files skipped from review due to trivial changes (3)
  • .github/workflows/api.yml
  • .vscode/launch.json
  • api/requirements.txt
Additional Context Used
LanguageTool (5)
api/ReadMe.md (5)

Near line 4: Consider using either the past participle “installed” or the present participle “installing” here.
Context: ...# Start in local

assuming python is install, open code in visual studio code, right...


Near line 6: You might be missing the article “a” here.
Context: ... run Python.

This will ask to create virtual environment, slect .venv and all requir...


Near line 6: In standard English, the noun “softwares” is uncountable. Consider using an alternative.
Context: ...vironment, slect .venv and all required softwares are installed

then open terminal and...


Near line 8: You might be missing the article “the” here.
Context: ...stalled

then open terminal and issue below command to set up look up data


---

Near line 8: Adverb repetition.
Context: ...terminal and issue below command to set up look up data

```shell 
python manage.py mig...

</blockquote></details>

</blockquote></details>

</details>
<details><summary>Additional comments not posted (2)</summary><blockquote>
<details><summary>docker-compose.yml (2)</summary><blockquote>

`33-33`: Confirm the usage of the `latest-pg16` tag for the `timescaledb` image.

<details>
<summary>Verification successful</summary>



---

The verification script has confirmed that the `latest-pg16` tag for the `timescaledb` image is used in the `docker-compose.yml` file. The output shows that this tag appears exactly as specified in the file, and no other versions or tags of the `timescaledb` image are mentioned. This confirms the usage as intended in the Docker configuration.

---

**Usage of `latest-pg16` tag for `timescaledb` image confirmed.**
- The `docker-compose.yml` file correctly uses the `timescale/timescaledb:latest-pg16` image as specified.



</details>

<details>
<summary>Scripts Executed</summary>

The following scripts were executed for the analysis:



---

Script:
```shell
#!/bin/bash
# Description: Verify the usage of the `latest-pg16` tag for the `timescaledb` image.

# Test: Search for the `timescaledb` image usage. Expect: Only occurrences of the `latest-pg16` tag.
rg --type yaml $'image: timescale/timescaledb:latest-pg16'

Length of output: 123


86-96: Review the configuration for the newly added pgadmin service.

Ensure that the environment variables and port configurations are correctly set according to your project requirements.

api/ReadMe.md Outdated Show resolved Hide resolved
api/ReadMe.md Outdated Show resolved Hide resolved
api/ReadMe.md Outdated Show resolved Hide resolved
Comment on lines +15 to +17
```shell
python manage.py runserver
```
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure fenced code blocks are surrounded by blank lines and the file ends with a newline.

+ 
  python manage.py runserver
+ 

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
```shell
python manage.py runserver
```

python manage.py runserver

@rajadilipkolli rajadilipkolli merged commit 2c880d6 into main May 11, 2024
1 check passed
@rajadilipkolli rajadilipkolli deleted the renovate/celery-5.x branch May 11, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant