Allow custom registries without trailing slash #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, configuring the npm setting @foo:registry to the following values would give these results: https://example.com/npm => https://example.com/%40foo%2fbar https://example.com/npm/ => https://example.com/npm/%40foo%2fbar After this change, however, leniency is allowed for trailing slashes, giving the following results: https://example.com/npm => https://example.com/npm/%40foo%2fbar https://example.com/npm/ => https://example.com/npm/%40foo%2fbar
1 task
raineorshine
approved these changes
Aug 5, 2024
|
Thank you! |
|
A unit test to prevent this from happening instead of a comment would be nice! |
|
@bashbers quoting my response to the original PR:
Looking forward to your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, configuring the npm setting @foo:registry to the following values would give these results:
After this change, however, leniency is allowed for trailing slashes, giving the following results:
fixes #1439