Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing typo #2509

Closed
wants to merge 1 commit into from
Closed

fixing typo #2509

wants to merge 1 commit into from

Conversation

VRRmax
Copy link
Contributor

@VRRmax VRRmax commented Mar 24, 2020

comments in .erb is with <%# ... %>

comments in .erb is with <%# ... %>
@jakeNiemiec
Copy link
Member

jakeNiemiec commented Mar 24, 2020

See: #1386 Sorry, my bad.

@jakeNiemiec jakeNiemiec reopened this Mar 24, 2020
@VRRmax
Copy link
Contributor Author

VRRmax commented Mar 25, 2020

I don't understand why you use <%%= instead of <%#= which is the standard way for ERB commenting. That's the point of my PR, which is different than the ones you referred to me.
<%%= looks like a typo, and you will have PR again and again, people thinking you meant '<%=' by '<%%='.

Replacing '<%%=' by '<%#=' seems legit.

Please tell me if I have a misconception somewhere.

@VRRmax
Copy link
Contributor Author

VRRmax commented Mar 26, 2020

#1382 (comment)

@olleolleolle
Copy link
Contributor

The %% is meant to be there, so that the output can be visible to the user reading it as %.

The output text is a JS comment to be read by the developer learning from the example.

Hope this helps explain why the %% is not a typo.

@VRRmax VRRmax closed this Mar 27, 2020
@VRRmax VRRmax deleted the patch-1 branch March 27, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants