-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Hello Erb" example error #1386
Conversation
// Run this example by adding <%= javascript_pack_tag 'hello_erb' %> to the head of your layout file, | ||
// like app/views/layouts/application.html.erb. | ||
// Run this example by adding <%%= javascript_pack_tag 'hello_erb' %> to the head of your layout file, | ||
// like app/views/layouts/application.html.erb. Please take care of removing the extra `%` from `<%%=`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO there is no need for that extra line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which line do you mean? This one? // we can't write the correct ERB tags here, they would get interpreted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was referring to Please take care of removing the extra
%from
<%%=: // we can't write the correct ERB tags here, they would get interpreted.
I assume dev will just copy <%%= javascript_pack_tag 'hello_erb' %>
and use it. But that's just an opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, yes but <%%= javascript_pack_tag 'hello_erb' %>
doesn't work as it is, you must use <%= javascript_pack_tag 'hello_erb' %>
; it's a hint for the user.
Is that any better? |
Much better than mine for sure |
Fix #1382