Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused argument in .db_configs_with_versions #50425

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Remove unused argument in .db_configs_with_versions #50425

merged 1 commit into from
Dec 21, 2023

Conversation

wildmaples
Copy link
Contributor

Motivation / Background

db_configs is unused in db_configs_with_versions

Detail

Remove the method argument

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@wildmaples wildmaples changed the title Remove unused argument Remove unused argument in .db_configs_with_versions Dec 21, 2023
jonathanhefner
jonathanhefner approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@jonathanhefner jonathanhefner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like that parameter become unnecessary due to 901828f#diff-cb5c658a1aa7877862198142775880b76b1d327ade6fd39f7c29a080535de6b7L266-R260.

@jonathanhefner jonathanhefner merged commit b1d57fb into rails:main Dec 21, 2023
3 of 4 checks passed
@jonathanhefner
Copy link
Member

Thank you, @wildmaples! ✂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanhefner jonathanhefner jonathanhefner approved these changes

Assignees
No one assigned
Labels
activerecord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wildmaples @jonathanhefner