Cleanup after signing changed #4354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to add `cmdids` to these messages. For planned solutions see raiden-network/raiden-contracts#1110 and #4297.
In #4284 I tried to keep all signatures identical. Now it's obvious that all `EnvelopeMessage` subclasses have a signature that is based on a BP with all additional fields put into the `additional_hash`. Due to this construction, the `message_hash` which is used to calculate the `additional_hash` can be reduced to all fields that are not already included in the BP. The padding is also unnecessary and was only included to preserve the old behaviour during the large refactoring PR mentioned above. It's usually a good idea to separate refactoring and behavior changes.
Codecov Report
@@ Coverage Diff @@
## develop #4354 +/- ##
==========================================
Coverage ? 80.21%
==========================================
Files ? 102
Lines ? 13813
Branches ? 2148
==========================================
Hits ? 11080
Misses ? 2113
Partials ? 620
Continue to review full report at Codecov.
|
hackaugusto
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some additional cleanup after the refactoring in #4284.
This changes the signatures of all
EnvelopeMessages. So if that is a problem, block this PR!