-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove create user endpoint and serializer 518 #545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thin PR!
@riatzukiza Some linting issues no this one too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@riatzukiza This is great - just one very small change. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request changes...
There is an overly permissive unnessisary endpoint for adding users to the system. It needs to be removed
FUNCTIONALITY
Fixes #518
Removes create user view mixin from user api view, also removes a serializer which was only used by the no longer nessisary create user view.
TO TEST
Run `docker-compose run web -c 'pytest -x'. The x causes the test suite to abort after the first failed tests. If all tests pass, nothing has been broken by this pr.
Additionally, attempt to call the api end point
POST /v1/user
This pull request is ready to merge when...