Remove create user endpoint and serializer 518 #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@riatzukiza Some linting issues no this one too |
carltonsmith
suggested changes
Feb 15, 2021
There was a problem hiding this comment.
@riatzukiza This is great - just one very small change. Thanks!
carltonsmith
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes...
There is an overly permissive unnessisary endpoint for adding users to the system. It needs to be removed
FUNCTIONALITY
Fixes #518
Removes create user view mixin from user api view, also removes a serializer which was only used by the no longer nessisary create user view.
TO TEST
Run `docker-compose run web -c 'pytest -x'. The x causes the test suite to abort after the first failed tests. If all tests pass, nothing has been broken by this pr.
Additionally, attempt to call the api end point
POST /v1/userThis pull request is ready to merge when...