Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Action to create Docker image #392

Merged
merged 6 commits into from
Jan 15, 2024

Conversation

tschumpr
Copy link
Contributor

This action builds a docker image whenever a new release is published. The image is named after the release tag, e.g. tag v.3.1.0-test results in the image 3.1.0.-test.

@pedroetb
Copy link

pedroetb commented Dec 1, 2023

Hi @tschumpr, thanks for your contribution!

I was trying to use this image https://github.com/GeoWerkstatt/stac-browser/pkgs/container/stac-browser (image ghcr.io/geowerkstatt/stac-browser:3.1.0) but it's not working. I'm getting only a white page and errors while loading app.js and chunk-vendors.js.

image

Same configuration is working for me when using an image built by myself from https://github.com/radiantearth/stac-browser/tree/ae7e5cf1c98dc7cd9c03f5e1a4d333556e345b8e.

@pedroetb
Copy link

pedroetb commented Dec 1, 2023

After checking it twice, now I see that your image is trying to get resources from path /browser, instead of /. I made a symlink at Nginx for testing, /usr/share/nginx/html/browser pointing to /usr/share/nginx/html , and it's working.

Maybe you set this path prefix at build time for ghcr.io/geowerkstatt/stac-browser:3.1.0 image?

@tschumpr
Copy link
Contributor Author

tschumpr commented Dec 1, 2023

@pedroetb We had to do the adjustment of /browser in our fork for some internal reasons but these changes are not part of this PR. If you want to test the image created with the changes in this PR, you can use the one from my private fork, the publish script is the exact same: https://github.com/tschumpr/stac-browser/pkgs/container/stac-browser.

@pedroetb
Copy link

pedroetb commented Dec 1, 2023

Wow @tschumpr that was fast! Nice, already tested and working great for me, thanks!

When this PR gets merged (I hope so), I will migrate to ghcr.io/radiantearth/stac-browser image.

@m-mohr
Copy link
Collaborator

m-mohr commented Dec 29, 2023

What do my Docker magicians think about this? Sounds like a good idea, I just don't have a clue about it myself. @geospatial-jeff @waystilos @constantinius

@waystilos
Copy link
Collaborator

waystilos commented Dec 31, 2023

What do my Docker magicians think about this? Sounds like a good idea, I just don't have a clue about it myself. @geospatial-jeff @waystilos @constantinius

lgtm! I just had one comment but other than that, it looks good. Happy new year!

Copy link
Collaborator

@waystilos waystilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we want to have the 'v' prefix from the tag name for the version?

@waystilos waystilos self-requested a review December 31, 2023 07:32
.gitattributes Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@m-mohr
Copy link
Collaborator

m-mohr commented Jan 11, 2024

Looks good to me. Left 3 minor comments. Once these are resolved, we I can merge this @tschumpr. Thanks for the PR.

Do I need to enable Packages on GitHub or something like that?

tschumpr and others added 4 commits January 15, 2024 09:08
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
@tschumpr
Copy link
Contributor Author

Looks good to me. Left 3 minor comments. Once these are resolved, we I can merge this @tschumpr. Thanks for the PR.

Do I need to enable Packages on GitHub or something like that?

@m-mohr The necessary packages should be enabled by default. Otherwise we'll see it if the action fails.

@m-mohr
Copy link
Collaborator

m-mohr commented Jan 15, 2024

Thanks, let's see how it goes...

@m-mohr m-mohr merged commit d8f89b7 into radiantearth:main Jan 15, 2024
@m-mohr m-mohr added this to the 3.1.1 milestone Jan 15, 2024
@m-mohr m-mohr modified the milestones: 3.1.1, 3.2.0 Mar 7, 2024
silvester-pari pushed a commit to EOEPCA/open-science-catalog-stac-browser that referenced this pull request May 29, 2024
* Add action to build image on release

Co-authored-by: Matthias Mohr <matthias@mohr.ws>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants