added romanian translation #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mohr
reviewed
Feb 12, 2023
m-mohr
reviewed
Feb 12, 2023
m-mohr
reviewed
Feb 12, 2023
|
Thanks a lot! This looks great! I added a couple of minor comments to ensure everything is consistent/complete. Once I have your confirmation on these, happy to merge! Edit: Please also add "ro" to the config.js as last element of the list: https://github.com/radiantearth/stac-browser/blob/dev/config.js#L18 I've also sent you an invite for this repo so that you can be the codeowner of this language pack. Please add yourself here: |
|
Thanks a lot, great to see this language in STAC Browser! If you have any updates, just create a new PR so that we can get them merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added an initial Romanian translation. Most of EO/RS terms have been validated with industry experts. Some of the statistics related terms ar almost agreed upon but we expect changes in the near term based on feedback from the math community.
We see the translation to be ready for integration.