-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Frensh language files #248
Conversation
@@ -0,0 +1,3 @@ | |||
const format = 'YYYY-MM-DD'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can remember in France they use DD/MM/YYYY, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good point. We might consider supporting some regional setting in parallel of localization, because 'YYYY-MM-DD' is definitely the preferable date format for fr-CA (as for en-CA). But this might be different for other regions such fr-FR or en-US.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we could do that. I need to check how we can make this easily possible without duplicating all the phrases though.
For now you could also just store the files in a fr_CA folder and make it really specific for Canada (then the config should be aligned to that, of couse.)
"invalidStacCollections": "La réponse de l'API n'est pas une liste valide de collections STAC.", | ||
"invalidStacItems": "La réponse de l'API n'est pas une liste valide d'éléments STAC.", | ||
"labels": { | ||
"cause": "Cause:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an oversight or just the same?
src/locales/fr/texts.json
Outdated
"api": "API", | ||
"catalog": "Catalogue", | ||
"load": "Charger", | ||
"selectStacIndex": "... ou en sélectionner un dans l'index STAC:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"dans STAC Index"? STAC Index is a name so I think it shouldn't be translated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe STAC acts as a qualifier of the type of index, then 'index STAC' is more readable (noun + qualifier) and similar to 'la collection STAC' and 'le catalogue STAC' used elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... but you don't change names, right? "STAC Index" is a name for a website, i.e. stacindex.org.
The company "United Airlines" would still be "United Airlines" in French and not e.g. "airlines unies", right?
}, | ||
"source": { | ||
"detailsAboutSource": "À propos de la source STAC", | ||
"label": "Source", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an oversight or just the same?
Thanks, I think we can merge this, right? |
Yes! Please proceed. |
* First draft for i18n support #123 * Async loading for languages, translate bootstrap and sidebar * Translate zoom control * Further translations * Persist language in URL, further translations, bugfixes, separate component for provider roles, ... * More translations... * Translations for errors, search and filtering, bug fixes * Localize datepicker * Fix lint issues * Adding Frensh language files (#248) Co-authored-by: Jean-François Bourgon <jean-francois.bourgon@canada.ca> * Implement language switching for static catalogs, send Accept-Header, fix invalid references to phrase contactProvider * Fix language switching based on Browser settings * Started translating metadata * Minor improvements * Allow selecting "incomplete" languages * Improve table rendering for languages * Add locales from stac-fields * Added more French language labels Co-authored-by: Jean-François Bourgon <jean-francois.bourgon@canada.ca> * German translations etc. * Initialize uiLanguage correctly * Add media type based texts * Further German translations * Additional translations * Implement basic API language support * Further translations * Fixed typo * initial French translation of STAC fields * Add missing translation and clean-up * Add missing translations * Reusable phrases --------- Co-authored-by: Jean-François Bourgon <jean-francois.bourgon@canada.ca>
@jfbourgon