Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show conformsTo on landing page of OAFeat #88

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Show conformsTo on landing page of OAFeat #88

merged 1 commit into from
Dec 9, 2020

Conversation

m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented Dec 9, 2020

Related Issue(s): #87 (comment)

Proposed Changes:

  1. Quick fix to include conformsTo on OAFeat landing page

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@m-mohr m-mohr added this to the 1.0.0-beta.1 milestone Dec 9, 2020
@m-mohr m-mohr mentioned this pull request Dec 9, 2020
@cholmes
Copy link
Collaborator

cholmes commented Dec 9, 2020

So I'm 100% clear - this means we don't have to change the markdown? Our openapi will combine right?

And should I merge this with the decision to not include the combined doc in this release? Or leave it for next release?

@m-mohr
Copy link
Collaborator Author

m-mohr commented Dec 9, 2020

@cholmes This basically is a bugfix independent of the combine issue, it just adds the missing field comformsTo to the landing page of OAFeat, which I forgot in #82. So no markdown change require AFAIK, conformsTo will be on the landing page always. It should improve the merge situation, but not solve it entirely, see discussions in #87.

@cholmes
Copy link
Collaborator

cholmes commented Dec 9, 2020

gotcha

@cholmes cholmes merged commit 1f150d1 into master Dec 9, 2020
@cholmes cholmes deleted the patch01 branch December 9, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants