New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert change to limit definition in 1.0.0-rc.2 to align with current… #358

Merged

philvarner merged 1 commit into radiantearth:main from philvarner:pv/revert-limit-definition

Nov 7, 2022

Collaborator

philvarner commented Nov 6, 2022

… ogcapi defintion

Related Issue(s):

Revert limit behavior changed in 1.0.0-rc.2 to previous #357

Proposed Changes:

in rc.2, the definition of limit was changed such that if a value over the maximum were provided, a 400 error should be returned. However, the definition of this behavior in OAFeat 1.0 is inconsistently defined, and has been changed in the latest draft of that spec such that a limit above the maximum is treated as if it were the maximum and not an error. This PR reverts the language to added in rc.2 that an error should be returned.

This PR has no breaking changes.
This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.


          revert change to limit definition in 1.0.0-rc.2 to align with current…

1ce286b

… ogcapi defintion

philvarner requested review from cholmes, m-mohr and matthewhanson

November 6, 2022 15:32

m-mohr approved these changes

View reviewed changes

philvarner merged commit 2e3eb8a into radiantearth:main

philvarner deleted the pv/revert-limit-definition branch

November 7, 2022 13:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet