Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code samples using the http type to use none #341

Merged

Conversation

philvarner
Copy link
Collaborator

Related Issue(s):

  • n/a

Proposed Changes:

  1. fix code samples using the http type to use none, since none of these were http format, they showed red highlights in GH

PR Checklist:

  • This PR has no breaking changes.
  • This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

… were http format, they showed red highlights in GH
@philvarner philvarner added this to the 1.0.0-rc.2 milestone Oct 13, 2022
@m-mohr
Copy link
Collaborator

m-mohr commented Oct 13, 2022

What would be HTTP format?

@philvarner philvarner merged commit ddcabe4 into radiantearth:main Oct 13, 2022
@philvarner philvarner deleted the pv/fix-code-samples-using-http branch October 13, 2022 12:45
@philvarner
Copy link
Collaborator Author

What would be HTTP format?

I don't actually know -- it's supposed to be for the mime type message/http, but I can't find an example of what that actually looks like

@m-mohr
Copy link
Collaborator

m-mohr commented Oct 13, 2022

I guess they want the full header with status codes etc...

200 OK
Content-Type: text/html

or

GET /
Host: example.com
Accept: text/html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants