Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional numberMatched and numberReturned fields to ItemCollection #338

Conversation

philvarner
Copy link
Collaborator

Related Issue(s):

  • n/a

Proposed Changes:

  1. add optional numberMatched and numberReturned attributes to ItemCollection. These are recommended for a OCG API - Features Part 1 implemenation of ../items and part of OGC Commons now. stac-server and resto already add these to both ../items and /search ItemCollection responses, and doing this in stac-fastapi would be trivial because of existing support for Context Extension. After making this change, I feel we can also deprecate the Context Extension, but that's a separate decision.

PR Checklist:

  • This PR has no breaking changes.
  • This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner modified the milestones: 1.0.0-rc.3, 1.0.0-rc.2 Oct 13, 2022
@philvarner philvarner merged commit 23b676d into radiantearth:main Oct 13, 2022
@philvarner philvarner deleted the pv/add-numberMatched-and-numberReturned-to-ic branch October 13, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants