Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update wording in transaction extension #310

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

philvarner
Copy link
Collaborator

Related Issue(s):

Proposed Changes:

  1. update wording in transaction extension

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner marked this pull request as ready for review July 15, 2022 02:15
ItemCollection contains two Items and one is successfully created and the other
fails to be created, the server is not required to then delete the successfully
created one. When only some of the Items in the ItemCollection are created, the
server should communicate this failure back to the client with an error status code.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be defined which error code should be used when only a partial update happened?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can. It could be any problem. I think the point here is that it's not atomic, and you may have partial updates, and that the server isn't required to enforce atomicity.

Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One issue that might be clarified in the comment above.

@philvarner philvarner merged commit 004ab64 into radiantearth:main Jul 26, 2022
@philvarner philvarner deleted the pv/txn-wording-updates branch July 26, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants