Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claify Transaction Extension behavior #271

Merged
merged 14 commits into from
Mar 17, 2022
Merged

Conversation

philvarner
Copy link
Collaborator

@philvarner philvarner commented Mar 2, 2022

Related Issue(s):

Proposed Changes:

  1. Clarify that PUT and PATCH cannot change the collection an item is in
  2. Clarify allowed HTTP status codes
  3. Allow partial Item and partial ItemCollection containing partial Items as POST input
  4. Allow partial Item containing partial Items as PUT input (but the server has to be able to derive a valid Item from it to return from the GET endpoint, e.g., by populating the id and collection fields or adding links)

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@@ -219,11 +278,6 @@ components:
$ref: '../../../core/commons.yaml#/components/schemas/link'
assets:
$ref: '../../../core/commons.yaml#/components/schemas/assets'
example:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this missed being deleted when this block was copied from the Item schema

CHANGELOG.md Outdated Show resolved Hide resolved
@philvarner
Copy link
Collaborator Author

@philvarner
Copy link
Collaborator Author

@philvarner
Copy link
Collaborator Author

@m-mohr ready for re-review

@philvarner philvarner requested a review from m-mohr March 4, 2022 14:21
@philvarner philvarner merged commit 59c8c1a into dev Mar 17, 2022
@philvarner philvarner deleted the pv/claify-txn-ext-semantics branch March 17, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants