update CQL2 definition to reference OGC API yaml file in github, update npm build #261
Conversation
| @@ -35,7 +35,6 @@ build/Release | |||
| # Dependency directories | |||
| node_modules/ | |||
| jspm_packages/ | |||
| package-lock.json | |||
There was a problem hiding this comment.
recommended practice is to commit package-lock.json
There was a problem hiding this comment.
For software yes, but for a specification? There I'd assume you'd want the latest version?
There was a problem hiding this comment.
I think for any build where you have dependencies. They're pinned to specific versions in it. Otherwise, anytime new build dependency versions could be resolved that no longer work with the current code, and there's no easy way to fix that, since you don't know what previous versions actually worked.
| @@ -0,0 +1 @@ | |||
| 16 | |||
There was a problem hiding this comment.
use nvmrc, and upgrade to node 16
There was a problem hiding this comment.
What's the reasoning? And why in a CQL PR?
There was a problem hiding this comment.
I was updating the openapi yaml, so I took the opportunity to update the build which mostly does validation while I was at it. I probably should have separated them into different PRs, but didn't.
| @@ -12,14 +12,15 @@ info: | |||
| name: Apache License 2.0 | |||
| url: 'http://www.apache.org/licenses/LICENSE-2.0' | |||
| tags: | |||
| - name: Core | |||
There was a problem hiding this comment.
fixes a few warnings.
| @@ -222,8 +222,6 @@ Formal definitions and grammars for CQL2 can be found here: | |||
| - [cql.bnf](https://github.com/opengeospatial/ogcapi-features/blob/master/extensions/cql/standard/schema/cql.bnf) | |||
| - [cql.json](https://github.com/opengeospatial/ogcapi-features/blob/master/extensions/cql/standard/schema/cql.json) | |||
| - [cql.yml](https://github.com/opengeospatial/ogcapi-features/blob/master/extensions/cql/standard/schema/cql.yml) | |||
| - A JSON Schema for only the parts of the CQL2 JSON encoding required by this extension is [here](cql.json) | |||
There was a problem hiding this comment.
edited cql.json has been removed, as we no longer have a custom version
philvarner
changed the title
philvarner
changed the title
Related Issue(s):
Proposed Changes:
PR Checklist:
stac-specdirectory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)