Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filterfragmentfixes #253

Merged
merged 3 commits into from
Jan 14, 2022
Merged

Conversation

bitner
Copy link
Collaborator

@bitner bitner commented Jan 13, 2022

Related Issue(s): #

Proposed Changes:

  1. Fix examples in fragments/filter/README.md so that cql2-text examples are exactly equivalent to cql2-json examples. (This allows use within tests to make sure that a cql2-text parser returns the same AST as a cql2-json parser.)

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@bitner
Copy link
Collaborator Author

bitner commented Jan 13, 2022

@philvarner I added some fixes to the examples so that the examples can be scraped and used to make sure that the pygeofilter cql2-text and cql2-json parsers have identical results.

@philvarner philvarner merged commit 58dc404 into radiantearth:dev Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants