Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg conformance uris, endpoints, links, and maturity classification #240

Conversation

philvarner
Copy link
Collaborator

@philvarner philvarner commented Dec 11, 2021

Related Issue(s): #232

Proposed Changes:

There are no effective changes in this PR, it simply reorganizes the content that was already there.

  1. Add core conformance link to all other classes
  2. Remove core link relations and endpoints in each other conformance class, and instead just reference core.
  3. Move the Maturity Classification out of Extensions, since the main conformance classes also use it.

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner changed the base branch from master to dev December 11, 2021 17:12
will require the spec to go to 2.0.0.
will require the spec to go to 2.0.0.

## Maturity Classification
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was moved from Extensions, since it applies to both the regular conformance classes and extensions

@@ -324,22 +305,10 @@ allows the client to suggest to the server which Item attributes should be inclu
through the use of a `fields` parameter. The full description of how this extension works can be found in the
[fields fragment](../fragments/fields/).

### Filter
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved Filter and Query to be next to each other

@philvarner philvarner changed the title Reorg conformance uris endpoint and links Reorg conformance uris, endpoints, links, and maturity classification Dec 14, 2021
@philvarner philvarner marked this pull request as ready for review December 14, 2021 18:24
@philvarner philvarner requested review from m-mohr, cholmes, jbants, lossyrob and matthewhanson and removed request for m-mohr December 14, 2021 18:25
@@ -46,8 +46,8 @@ for data in a different projection.

- **Working code required.** Proposed changes should be accompanied by working code
(ideally with a link to an online service running the code). A reference implementation should be available
online to power the interactive documentation. Fully accepted specifications should have at least 3 implementations
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what "fully accepted" means here, since 3 impls is what we call Candidate in the Maturity Classification model. Rewording to just not be inconsistent with the MC.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this predates extensions, and I think fully accepted was meant to mean like 1.0.0? Change looks good.

Copy link
Collaborator

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -46,8 +46,8 @@ for data in a different projection.

- **Working code required.** Proposed changes should be accompanied by working code
(ideally with a link to an online service running the code). A reference implementation should be available
online to power the interactive documentation. Fully accepted specifications should have at least 3 implementations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this predates extensions, and I think fully accepted was meant to mean like 1.0.0? Change looks good.

@philvarner philvarner merged commit b0e8995 into radiantearth:dev Jan 5, 2022
@philvarner philvarner deleted the reorg-conformance-uris-endpoint-and-links branch January 5, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants