Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix URI for Collections, and make other assorted typo and wordsmithing changes extracted from the browseable/children PR #234

Merged
merged 6 commits into from
Dec 7, 2021
Merged

fix URI for Collections, and make other assorted typo and wordsmithing changes extracted from the browseable/children PR #234

merged 6 commits into from
Dec 7, 2021

Conversation

philvarner
Copy link
Collaborator

@philvarner philvarner commented Dec 6, 2021 •
edited
Loading

Related Issue(s): #223

This fix is also in the browseable PR, but just breaking it out to get it in before that massive one.

Proposed Changes:

  1. use the correct Collection conformance class URI in the Collection spec

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner marked this pull request as draft December 6, 2021 15:46
@philvarner philvarner changed the title fix URI for Collections fix URI for Collections, and make other assorted typo and wordsmithing changes extracted from the browseable/children PR Dec 6, 2021
@philvarner philvarner marked this pull request as ready for review December 6, 2021 16:01
philvarner
philvarner commented Dec 6, 2021
View reviewed changes
README.md Show resolved Hide resolved
philvarner
philvarner commented Dec 6, 2021
View reviewed changes
overview.md Show resolved Hide resolved
m-mohr
m-mohr reviewed Dec 7, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
m-mohr
m-mohr reviewed Dec 7, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
m-mohr
m-mohr approved these changes Dec 7, 2021
View reviewed changes
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments that should be adressed, but nothing that is really blocking.
Otherweise, looks good, thanks for the breakout PR.

philvarner and others added 2 commits December 7, 2021 10:57
@philvarner @m-mohr
Update README.md
ccb63cf 
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
@philvarner @m-mohr
Update README.md
ba3c2ea 
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
@philvarner philvarner merged commit bfccb35 into radiantearth:dev Dec 7, 2021
@philvarner philvarner deleted the fix-collections-conformance-class branch December 7, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-mohr m-mohr m-mohr approved these changes

@cholmes cholmes Awaiting requested review from cholmes

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philvarner @m-mohr