Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: define paging for collections and items endpoint #221

Merged
merged 19 commits into from
Dec 3, 2021
Merged

feat: define paging for collections and items endpoint #221

merged 19 commits into from
Dec 3, 2021

Conversation

philvarner
Copy link
Collaborator

@philvarner philvarner commented Oct 7, 2021 •
edited
Loading

Related Issue(s): #152

Proposed Changes:

  1. Explicitly define the same pagination mechanism that works with Item Search to be used with STAC - Features items. This was already inherited from OGC API - Features, not explicitly defined in STAC.
  2. Definite what /collections pagination means.

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner marked this pull request as ready for review October 8, 2021 13:33
@philvarner philvarner marked this pull request as draft October 8, 2021 14:06
@philvarner philvarner marked this pull request as ready for review October 11, 2021 20:26
@philvarner philvarner changed the base branch from master to dev October 11, 2021 20:26
m-mohr
m-mohr reviewed Nov 3, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@philvarner philvarner changed the title feat: define paging for STAC - Features items endpoint feat: define paging for collections and items endpoint Nov 4, 2021
m-mohr
m-mohr reviewed Nov 27, 2021
View reviewed changes
ogcapi-features/README.md Outdated Show resolved Hide resolved
m-mohr
m-mohr reviewed Nov 27, 2021
View reviewed changes
ogcapi-features/README.md Outdated Show resolved Hide resolved
m-mohr
m-mohr reviewed Nov 27, 2021
View reviewed changes
ogcapi-features/README.md Outdated Show resolved Hide resolved
m-mohr
m-mohr reviewed Nov 27, 2021
View reviewed changes
ogcapi-features/README.md Outdated Show resolved Hide resolved
m-mohr
m-mohr reviewed Nov 27, 2021
View reviewed changes
ogcapi-features/README.md Outdated Show resolved Hide resolved
m-mohr
m-mohr reviewed Nov 27, 2021
View reviewed changes
ogcapi-features/README.md Outdated Show resolved Hide resolved
m-mohr
m-mohr reviewed Nov 27, 2021
View reviewed changes
ogcapi-features/README.md Outdated Show resolved Hide resolved
m-mohr
m-mohr requested changes Nov 27, 2021
View reviewed changes
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but some minor questions added or improvements requested.

cholmes
cholmes approved these changes Nov 27, 2021
View reviewed changes
Copy link
Collaborator

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

philvarner and others added 5 commits December 1, 2021 08:51
@philvarner @m-mohr
Update ogcapi-features/README.md
8cbf393 
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
@philvarner @m-mohr
Update ogcapi-features/README.md
dd8d955 
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
@philvarner @m-mohr
Update ogcapi-features/README.md
8705875 
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
@philvarner @m-mohr
Update ogcapi-features/README.md
1cfc02d 
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
@philvarner
reworded pagination options
b9efba7
@philvarner
Copy link
Collaborator Author

@m-mohr please re-review when you have a chance, thanks!

m-mohr
m-mohr reviewed Dec 3, 2021
View reviewed changes
ogcapi-features/README.md Outdated Show resolved Hide resolved
m-mohr
m-mohr approved these changes Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think there is a typo that needs to be fixed as indicated in the last comment.

@m-mohr m-mohr linked an issue Dec 3, 2021 that may be closed by this pull request
Pagination on results other than from Search #152
Closed
@philvarner philvarner merged commit 642878d into radiantearth:dev Dec 3, 2021
@philvarner philvarner deleted the paging-for-items branch December 3, 2021 16:24
@gadomski gadomski mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cholmes cholmes cholmes approved these changes

@m-mohr m-mohr m-mohr approved these changes

@jbants jbants jbants approved these changes

@lossyrob lossyrob Awaiting requested review from lossyrob

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagination on results other than from Search
4 participants
@philvarner @cholmes @m-mohr @jbants