Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorporate feedback on collections from beta.3, cleanup related text #210

Merged
merged 6 commits into from
Oct 5, 2021

Conversation

philvarner
Copy link
Collaborator

@philvarner philvarner commented Sep 9, 2021

incorporate feedback on collections from beta.3, cleanup related text in other components

Related Issue(s): #195

Proposed Changes:

  1. incorporate feedback from @m-mohr on collections
  2. fix more instances of should vs. shall/must

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner changed the title incorporate feedback on collections from beta.3, cleanup related text… incorporate feedback on collections from beta.3, cleanup related text Sep 9, 2021
@philvarner philvarner marked this pull request as ready for review September 9, 2021 16:21
CHANGELOG.md Outdated Show resolved Hide resolved
collections/README.md Outdated Show resolved Hide resolved
item-search/README.md Outdated Show resolved Hide resolved
ogcapi-features/README.md Outdated Show resolved Hide resolved
collections/README.md Outdated Show resolved Hide resolved
@philvarner
Copy link
Collaborator Author

@m-mohr I think I addressed all of your concerns here (thanks!)

@philvarner philvarner merged commit 2e96574 into radiantearth:dev Oct 5, 2021
@philvarner philvarner deleted the collections-feedback branch October 5, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants