Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clarifying language about using items instead of item #172

Merged
merged 10 commits into from
Aug 3, 2021

Conversation

philvarner
Copy link
Collaborator

Related Issue(s): #161

Proposed Changes:

  1. Add clarifying language about using link relation items instead of item

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • This PR does not make any changes to the core spec in the stac-spec directory (these are included as a subtree and should be updated directly in radiantearth/stac-spec)
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

overview.md Outdated
@@ -99,7 +99,7 @@ column is more of an example in some cases. OGC API makes some endpoint location
| `/api` | [OAFeat](ogcapi-features) | service-desc | OpenAPI 3.0 JSON | The OpenAPI definition of the endpoints in this service |
| **`/collections/{collectionId}`** | [OAFeat](ogcapi-features) | collection | Collection | Returns single Collection JSON |
| **`/collections/{collectionId}/items`** | [OAFeat](ogcapi-features) | items | ItemCollection | GeoJSON FeatureCollection-conformant entity of Item objects in collection |
| **`/collections/{collectionId}/items/{featureId}`** | [OAFeat](ogcapi-features) | Item | Returns single Item (GeoJSON Feature) | |
| **`/collections/{collectionId}/items/{featureId}`** | [OAFeat](ogcapi-features) | item | Returns single Item (GeoJSON Feature). This relation is defined by STAC, but its use is discouraged in STAC API, as Items should be referenced through their containing Collection rather than directly. | |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean? That items should be referenced through their containing Collection? What's the reason to discourage this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it should be discouraged per se, you could have a browsable API that has both child catalogs (and ultimately items). Or like @fredliporace has implemented I think, where the whole catalog is a normal static catalog with only the /search endpoint being dynamic.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewhanson yes, the API includes a child link to the static catalog. Did this to list a single entry in stacindex, that references both the search endpoint and the static catalog.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree. This should not be discouraged.
I think I'd say static catalogs should link to the API, too. And APIs should link to static catalogs, so that no matter where you start, you can find everything.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rewrote this in the README to be more clear -- I feel like I'm having a hard time expressing this well. please re-review.

overview.md Outdated Show resolved Hide resolved
ogcapi-features/README.md Outdated Show resolved Hide resolved
ogcapi-features/README.md Outdated Show resolved Hide resolved
ogcapi-features/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with the wording that APIs don't use item. It's OAFeat only that doesn't use item. So I tried to propose language that makes that more clear.

philvarner and others added 3 commits August 3, 2021 09:58
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>
@philvarner philvarner requested a review from m-mohr August 3, 2021 14:00
ogcapi-features/README.md Outdated Show resolved Hide resolved
ogcapi-features/README.md Outdated Show resolved Hide resolved
@philvarner philvarner merged commit 6c6b71c into radiantearth:dev Aug 3, 2021
@philvarner philvarner deleted the item-vs-items branch August 3, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants