Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CORS recommendation #131

Merged
merged 3 commits into from
May 14, 2021
Merged

Add CORS recommendation #131

merged 3 commits into from
May 14, 2021

Conversation

philvarner
Copy link
Collaborator

Related Issue(s): #99

Proposed Changes:

  1. Add recommendation to enable CORS for public APIs

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

m-mohr
m-mohr reviewed May 13, 2021
View reviewed changes
implementation.md Outdated Show resolved Hide resolved
m-mohr
m-mohr reviewed May 13, 2021
View reviewed changes
implementation.md Outdated Show resolved Hide resolved
m-mohr
m-mohr reviewed May 13, 2021
View reviewed changes
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments to resolve, otherwise LGTM

cholmes
cholmes approved these changes May 13, 2021
View reviewed changes
Copy link
Collaborator

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I agree with Matthias's comments.

@philvarner
Copy link
Collaborator Author

@m-mohr ready for re-review if you want to

@philvarner philvarner merged commit 5451049 into radiantearth:dev May 14, 2021
@philvarner philvarner deleted the cors branch May 14, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cholmes cholmes cholmes approved these changes

@m-mohr m-mohr m-mohr approved these changes

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philvarner @cholmes @m-mohr