Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't deactivate other search parameters when filtering with ids #125

Merged
merged 4 commits into from
May 5, 2021

Conversation

jisantuc
Copy link
Contributor

@jisantuc jisantuc commented May 5, 2021

Related Issue(s): stac-utils/stac-fastapi#124

Proposed Changes:

  1. Don't deactivate other query params when ids is passed to item search

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner
Copy link
Collaborator

Also just filed stac-utils/stac-fastapi-pgstac#31

@@ -63,7 +63,7 @@ The core parameters for STAC search are defined by OAFeat, and STAC adds a few p
| bbox | \[number] | OAFeat | Requested bounding box. Represented using either 2D or 3D geometries. The length of the array must be 2*n where n is the number of dimensions. The array contains all axes of the southwesterly most extent followed by all axes of the northeasterly most extent specified in Longitude/Latitude or Longitude/Latitude/Elevation based on [WGS 84](http://www.opengis.net/def/crs/OGC/1.3/CRS84). When using 3D geometries, the elevation of the southwesterly most extent is the minimum elevation in meters and the elevation of the northeasterly most extent is the maximum. |
| datetime | string | OAFeat | Single date+time, or a range ('/' seperator), formatted to [RFC 3339, section 5.6](https://tools.ietf.org/html/rfc3339#section-5.6). Use double dots `..` for open date ranges. |
| intersects | GeoJSON Geometry | STAC | Searches items by performing intersection between their geometry and provided GeoJSON geometry. All GeoJSON geometry types must be supported. |
| ids | \[string] | STAC | Array of Item ids to return. All other filter parameters that further restrict the number of search results (except `next` and `limit`) are ignored |
| ids | \[string] | STAC | Array of Item ids to return. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to rephrase this, but I think it's fine for now.

@jisantuc jisantuc changed the title Simplify search param interactions Don't deactivate other search parameters when filtering with ids May 5, 2021
@jisantuc jisantuc merged commit 7484ac9 into dev May 5, 2021
@jisantuc jisantuc deleted the js/simplify-search-param-interactions branch May 5, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants