Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up catalog references #112

Merged
merged 7 commits into from
May 12, 2021

Conversation

philvarner
Copy link
Collaborator

Related Issue(s): #111

Proposed Changes:

  1. make explicit that / returns a Catalog and not a Collection (this is implied by the schema, but not explicit in the textual description)
  2. add type field to Catalog openapi definition and example

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner changed the base branch from master to dev March 17, 2021 01:51
@m-mohr
Copy link
Collaborator

m-mohr commented Apr 26, 2021

As you've added the type field for Catalog, I'd think it should also add the type field for Collections, right?

@philvarner philvarner added this to the 1.0.0-beta.2 milestone May 5, 2021
@philvarner philvarner requested a review from cholmes May 11, 2021 15:52
@philvarner philvarner merged commit 8a5ceea into radiantearth:dev May 12, 2021
@philvarner philvarner deleted the tidy-up-catalog-references branch May 12, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change root endpoint (/) the be a Catalog, rather than a Collection or a Catalog
3 participants