Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify BBOX format #47

Closed
cholmes opened this issue Oct 26, 2020 · 3 comments
Closed

Clarify BBOX format #47

cholmes opened this issue Oct 26, 2020 · 3 comments
Milestone

Comments

@cholmes
Copy link
Collaborator

cholmes commented Oct 26, 2020

From @jjrom: 'The format of bbox is unclear from the specification. The astrea implementation waits for a comma separated delimiter string (i.e. lon1,lat1,lon2,lat2) while the Element84 implementation waits for an array i.e. ([lon1,lat1,lon2,lat2])'

He found that Features API is without an array, since we aiming to fully align with that I think we should use that, and make it clear.

@jisantuc
Copy link
Contributor

fwiw Franklin also assumes no array brackets for bboxes in query params

@jjrom
Copy link

jjrom commented Oct 26, 2020

Same for https://github.com/jjrom/resto - it also assumes no array brackes for bboxes in query params

@cholmes
Copy link
Collaborator Author

cholmes commented Nov 2, 2020

Am making a PR for this and it seems pretty clear. Will put in a few more warnings, but I think we mostly need to get @matthewhanson to update the element84 service.

cholmes added a commit that referenced this issue Nov 2, 2020
@cholmes cholmes mentioned this issue Nov 2, 2020
3 tasks
@cholmes cholmes added this to the 1.0.0-beta.1 milestone Nov 2, 2020
@m-mohr m-mohr closed this as completed Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants