Various test improvements #11582
Merged
Various test improvements #11582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjnilsson
force-pushed
the
testfixes-glorious-testfixes-and-other-improvements-hurray
branch
from
3c9b951
to
2750535
Compare
kjnilsson
changed the title
kjnilsson
force-pushed
the
testfixes-glorious-testfixes-and-other-improvements-hurray
branch
3 times, most recently
from
8ccbb51
to
ac6ea4b
Compare
test `confirm_nack` had a race condition that mean either ack or nack where likely outcomes. By stopping the queue before the publish we ensure only nack is the valid outcome.
By removing explicit meta data store groups.
kjnilsson
force-pushed
the
testfixes-glorious-testfixes-and-other-improvements-hurray
branch
from
beaea61
to
2b09891
Compare
kjnilsson
deleted the
testfixes-glorious-testfixes-and-other-improvements-hurray
branch
|
@Mergifyio backport v3.13.x |
✅ Backports have been created
|
michaelklishin
added a commit
that referenced
this pull request
Jul 1, 2024
michaelklishin
added a commit
that referenced
this pull request
Jul 1, 2024
Various test improvements (backport #11582)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
various flakes and speed improvements.